Fix str_split UPGRADE note - #9123
Closed
herndlm wants to merge 5 commits into
Closed
Conversation
herndlm
marked this pull request as ready for review
July 25, 2022 08:35
Member
|
Yes, this seems wrong. The same is in |
Contributor
Author
|
done, it was written a bit more vaguely there. documenting this clearly is not my strength.. |
cmb69
reviewed
Jul 25, 2022
| array_change_key_case and sorting with SORT_FLAG_CASE use ASCII case | ||
| conversion. | ||
| . str_split no longer returns an empty array on empty string. | ||
| . str_split returns an empty array on empty string. |
Member
There was a problem hiding this comment.
We might also mention the previous behavior
Contributor
Author
There was a problem hiding this comment.
I did something. let me know what you think. Again, technical documentation is maybe not my strong point :)
cmb69
reviewed
Jul 25, 2022
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I'm not completely mistaken (and I had my coffee already 😅) this needs to be negated. Just noticed this when I wanted to adapt phpstan and link to the UPGRADE note.
See also e809254, #8945 and https://3v4l.org/XfZO4 vs https://3v4l.org/XfZO4/rfc#vgit.master
Fyi @mvorisek